feat: courier template configs #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.8 #2156 +/- ##
==========================================
+ Coverage 75.70% 75.84% +0.14%
==========================================
Files 295 296 +1
Lines 15715 15858 +143
==========================================
+ Hits 11897 12028 +131
- Misses 2963 2971 +8
- Partials 855 859 +4
Continue to review full report at Codecov.
|
Benehiko
force-pushed
the
courier-templates-configs
branch
from
3539f77
to
f32ef51
Compare
aeneasr
requested changes
Jan 28, 2022
There was a problem hiding this comment.
Thank you! This looks really solid. A few follow ups:
- Could you please add documentation to the courier section which explains how to customize individual templates?
- Is it possible to load only one template from a custom source, and then all other templates are used from the default source?
- Could you customize the recovery or verification e2e test and set one custom template and then, in the respective e2e test, ensure that the custom template is being used? You can add one or two custom templates to here and then assert the contents around here. Alternatively you could also update the config on demand in the e2e test and write an individual test just for the custom template as e2e. To set a custom config value within your test, see here and subsuquently here. I recommend using base64 based template loading to make your life easier.
- Can you please add a schema test to verify that your JSON Schema is correct?
Benehiko
force-pushed
the
courier-templates-configs
branch
from
658c2a3
to
d399750
Compare
|
@Benehiko are you waiting for a review on this one? |
|
I'm still writing e2e tests, it's almost ready |
Benehiko
force-pushed
the
courier-templates-configs
branch
from
6621437
to
5b5024e
Compare
added 2 commits
February 4, 2022 15:19
7 tasks
|
Should be good to go on green CI |
Benehiko
force-pushed
the
courier-templates-configs
branch
from
cefde10
to
db1e92a
Compare
aeneasr
requested changes
Feb 7, 2022
aeneasr
requested changes
Feb 7, 2022
aeneasr
reviewed
Feb 8, 2022
aeneasr
approved these changes
Feb 8, 2022
aeneasr
pushed a commit
that referenced
this pull request
Feb 11, 2022
It is now possible to override individual courier email templates using the configuration system! Closes #2054
aeneasr
pushed a commit
that referenced
this pull request
Feb 14, 2022
It is now possible to override individual courier email templates using the configuration system! Closes #2054
This was referenced Mar 9, 2022
Merged
7 tasks
peturgeorgievv
pushed a commit
to senteca/kratos-fork
that referenced
this pull request
Jun 30, 2023
It is now possible to override individual courier email templates using the configuration system! Closes ory#2054
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Implements: #2054
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments